Skip to content

Commit

Permalink
New Chromedriver version that fixes the Mac issue.
Browse files Browse the repository at this point in the history
Fixes
#1968 so we can renmove
our fix.
  • Loading branch information
soulgalore committed Aug 15, 2023
1 parent 28bd484 commit 780affd
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 16 deletions.
8 changes: 0 additions & 8 deletions lib/chrome/webdriver/setupChromiumOptions.js
Original file line number Diff line number Diff line change
Expand Up @@ -189,14 +189,6 @@ export function setupChromiumOptions(

if (browserOptions.binaryPath) {
seleniumOptions.setChromeBinaryPath(browserOptions.binaryPath);
} else {
// Fix for https://github.com/sitespeedio/browsertime/issues/1968
// Same settings for Chrome/Edge
if (options.browser === 'chrome' && platform() === 'darwin') {
seleniumOptions.setChromeBinaryPath(
'/Applications/Google Chrome.app/Contents/MacOS/Google Chrome'
);
}
}

if (browserOptions.mobileEmulation) {
Expand Down
14 changes: 7 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"dependencies": {
"@cypress/xvfb": "1.2.4",
"@devicefarmer/adbkit": "2.11.3",
"@sitespeed.io/chromedriver": "115.0.5790-98b",
"@sitespeed.io/chromedriver": "115.0.5790-170",
"@sitespeed.io/edgedriver": "115.0.1901-183",
"@sitespeed.io/geckodriver": "0.33.0",
"@sitespeed.io/throttle": "5.0.0",
Expand Down

0 comments on commit 780affd

Please sign in to comment.