Fix for Chromedriver 115 bug.

#1968
sitespeedio · Jul 21, 2023 · cc03cbd · cc03cbd
1 parent e086c37
commit cc03cbd
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 28 deletions.
diff --git a/lib/chrome/webdriver/setupChromiumOptions.js b/lib/chrome/webdriver/setupChromiumOptions.js
@@ -1,4 +1,5 @@
 import { readFileSync } from 'node:fs';
+import { platform } from 'node:os';
 import intel from 'intel';
 import { chromeDesktopOptions as defaultChromeOptions } from '../settings/chromeDesktopOptions.js';
 import { chromeAndroidOptions as defaultAndroidChromeOptions } from '../settings/chromeAndroidOptions.js';
@@ -188,6 +189,14 @@ export function setupChromiumOptions(
 
   if (browserOptions.binaryPath) {
     seleniumOptions.setChromeBinaryPath(browserOptions.binaryPath);
+  } else {
+    // Fix for https://github.com/sitespeedio/browsertime/issues/1968
+    // Same settings for Chrome/Edge
+    if (options.browser === 'chrome' && platform() === 'darwin') {
+      seleniumOptions.setChromeBinaryPath(
+        '/Applications/Google Chrome.app/Contents/MacOS/Google Chrome'
+      );
+    }
   }
 
   if (browserOptions.mobileEmulation) {

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -7,7 +7,7 @@
   "dependencies": {
     "@cypress/xvfb": "1.2.4",
     "@devicefarmer/adbkit": "2.11.3",
-    "@sitespeed.io/chromedriver": "114.0.5735-90",
+    "@sitespeed.io/chromedriver": "115.0.5790-98b",
     "@sitespeed.io/edgedriver": "113.0.1774-9b",
     "@sitespeed.io/geckodriver": "0.33.0",
     "@sitespeed.io/throttle": "5.0.0",