Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEXT Tailwind Plugin Refactor #2431

Merged
merged 62 commits into from
Jan 28, 2024
Merged

NEXT Tailwind Plugin Refactor #2431

merged 62 commits into from
Jan 28, 2024

Conversation

endigo9740
Copy link
Contributor

@endigo9740 endigo9740 commented Jan 17, 2024

Linked Issue

Closes #2360

Description

Refactor the theme format and Tailwind plugin.

Copy link

changeset-bot bot commented Jan 17, 2024

⚠️ No Changeset found

Latest commit: 082cca1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
skeleton-docs ❌ Failed (Inspect) Jan 28, 2024 7:27pm

@endigo9740 endigo9740 changed the title Feat/next tailwind plugin NEXT Tailwind Plugin Refactor Jan 17, 2024
@endigo9740
Copy link
Contributor Author

@niktek @AdrianGonz97 this PR is now ready to merge. This is a huge first step towards v3 and will help unblock everything that comes next. So I cannot under emphasize the importance of getting this in. That said, I'd welcome a review by you two, but otherwise I'd say we go ahead and merge and follow up with any other additional changes or improvements over time, in smaller PRs.

Note that once this is merged, any v2 /site apps that relied on tw-plugin will no longer be in a functional state on the next branch. This is becausethe theme format, Tailwind components, etc have changed dramatically. So I'll leave it up to your discretion how we move forward with that.

Currently we'll only have ONE functional theme, called /themes/next.ts. But once the generator is operational, we'll expand with additional options and can look into features such as theme switching for the Astro docs.

@niktek given the CI/CD errors on this page are Vercel-related, let me know if you need anything from me to help troubleshoot. But this SHOULD be deployed to the CF instance and should be operational here:
https://next.skeleton.dev/

Note I'll be away for part of the afternoon, but back on later tonight or this week.

Thanks guys!

Copy link
Contributor

@niktek niktek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some superficial comments to worry about. Will get this deployed soon

sites/next.skeleton.dev/package.json Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AdrianGonz97 be good to know some of the background design decisions behind going the exec route. I can see on the one hand that it offers flexibility in updating what needs to be built without having to touch this code. The error swallowing issue is now resolved. Using https://vitejs.dev/guide/api-javascript#build directly via API might give us better error handling options - but there might be other issues.

@endigo9740
Copy link
Contributor Author

@niktek @AdrianGonz97 I've implemented the changes discussed above and on Discord. Minus of course a few things that Adrian will need to be involved in:

  1. A fix for the OS dark mode setting. See the issue outlined here.
  2. Nik's comment above around the exec method of the scripts
  3. Updates to the Theme type, which I'd like Adrian to be involved in as well (removing properties_dark, etc)

That said, let's plan to follow these as follow ups. I will now move forward with merging this into the next branch. We can follow up on plans for the above anytime this upcoming week.

@endigo9740 endigo9740 merged commit f4992d1 into next Jan 28, 2024
1 check failed
@endigo9740 endigo9740 deleted the feat/next-tailwind-plugin branch January 28, 2024 19:30
@endigo9740 endigo9740 mentioned this pull request Jan 29, 2024
27 tasks
@endigo9740 endigo9740 mentioned this pull request Mar 14, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants