Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(MEV): Updating MEV Lane with Testing + Cleaner Implementation #134

Merged
merged 3 commits into from
Oct 4, 2023

Conversation

davidterpay
Copy link
Contributor

No description provided.

@davidterpay davidterpay marked this pull request as ready for review September 28, 2023 18:59
@davidterpay davidterpay added backport/v1.x.x Backport your PR to the v1.x.x release backport/v2.x.x Backport your PR to the v2.x.x release labels Sep 28, 2023
Copy link
Contributor

@nivasan1 nivasan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@davidterpay davidterpay merged commit d495b38 into main Oct 4, 2023
8 checks passed
@davidterpay davidterpay deleted the terpay/mev-update branch October 4, 2023 22:23
mergify bot pushed a commit that referenced this pull request Oct 4, 2023
)

* updating mev lane with cleaner impl

* nit

* lint

(cherry picked from commit d495b38)
mergify bot pushed a commit that referenced this pull request Oct 4, 2023
)

* updating mev lane with cleaner impl

* nit

* lint

(cherry picked from commit d495b38)

# Conflicts:
#	block/mocks/lane.go
#	lanes/mev/mev_test.go
#	tests/integration/block_sdk_suite.go
davidterpay added a commit that referenced this pull request Oct 4, 2023
) (#139)

* updating mev lane with cleaner impl

* nit

* lint

(cherry picked from commit d495b38)

Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com>
davidterpay added a commit that referenced this pull request Oct 5, 2023
)

* updating mev lane with cleaner impl

* nit

* lint

(cherry picked from commit d495b38)

# Conflicts:
#	block/mocks/lane.go
#	lanes/mev/mev_test.go
#	tests/integration/block_sdk_suite.go
davidterpay added a commit that referenced this pull request Oct 5, 2023
…ackport #134) (#138)

* feat(MEV): Updating MEV Lane with Testing + Cleaner Implementation (#134)

* updating mev lane with cleaner impl

* nit

* lint

(cherry picked from commit d495b38)

# Conflicts:
#	block/mocks/lane.go
#	lanes/mev/mev_test.go
#	tests/integration/block_sdk_suite.go

* tidy and fix

---------

Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com>
Co-authored-by: David Terpay <david.terpay@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v1.x.x Backport your PR to the v1.x.x release backport/v2.x.x Backport your PR to the v2.x.x release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants