fix(auction): Adding extra check on bundler timeouts #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidterpay
added
backport/v1.x.x
nivasan1
reviewed
Oct 13, 2023
| bidTimeout := bidInfo.Timeout | ||
|
|
||
| for index, bundleTimeout := range bidInfo.TransactionTimeouts { | ||
| signers := bidInfo.Signers[index] |
There was a problem hiding this comment.
nit: comment here would be nice, spent some time tryna figure out what this did (check if the bidder is signer of a sub-tx). May also attribute confusion to me being dumb 🔢
mergify bot
pushed a commit
that referenced
this pull request
Oct 13, 2023
* validate bundler txs * nits * lint (cherry picked from commit 339b927) # Conflicts: # tests/app/app.go # tests/integration/block_sdk_suite.go
mergify bot
pushed a commit
that referenced
this pull request
Oct 13, 2023
* validate bundler txs * nits * lint (cherry picked from commit 339b927)
This was referenced Oct 13, 2023
davidterpay
added a commit
that referenced
this pull request
Oct 13, 2023
davidterpay
added a commit
that referenced
this pull request
Oct 19, 2023
…157) * fix(auction): Adding extra check on bundler timeouts (#156) * validate bundler txs * nits * lint (cherry picked from commit 339b927) # Conflicts: # tests/app/app.go # tests/integration/block_sdk_suite.go * fix --------- Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> Co-authored-by: David Terpay <david.terpay@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR enforces that every transaction within a searchers bundle has the same timeout height as the bid transaction. By doing so, we ensure that searcher's bundled transactions are not included by other searchers in subsequent blocks in the case when their bid does not get selected.
Additionally, we limit bidding exclusively for the next block height. This is another mechanism to ensure that searchers do not have their bundles un-bundled.
Testing
Added integration unit tests testing the various different timeout scenarios.