Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct item index with header #73

Merged
merged 2 commits into from
Jul 7, 2021
Merged

Correct item index with header #73

merged 2 commits into from
Jul 7, 2021

Conversation

khoben
Copy link
Contributor

@khoben khoben commented Jul 7, 2021 •
edited
Loading

Guidelines

Fixes #72: incorrect item index passed to OnMenuItemClickListener if headerView is set.

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@khoben khoben requested a review from skydoves as a code owner July 7, 2021 05:32
@khoben khoben changed the title Correct item index with header (fixes #72) Correct item index with header Jul 7, 2021
skydoves
skydoves approved these changes Jul 7, 2021
View reviewed changes
Copy link
Owner

@skydoves skydoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thanks for your contribution!
An old Android SDK is really.. 😂

@skydoves
Copy link
Owner

skydoves commented Jul 7, 2021

Could you run ./gradlew spotlessApply command line?

@khoben
Copy link
Contributor Author

khoben commented Jul 7, 2021 •
edited
Loading

Could you run ./gradlew spotlessApply command line?

Done

@skydoves skydoves merged commit 31a572b into skydoves:master Jul 7, 2021
@khoben khoben deleted the fix/incorrect-item-id-with-header branch July 7, 2021 13:20
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skydoves skydoves skydoves approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect item index with header
2 participants
@khoben @skydoves