Support start and stop Azure instances #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suquark
changed the title
suquark
force-pushed
the
azure_start_stop
branch
from
d36e2f7
to
5fe06d1
Compare
suquark
force-pushed
the
azure_start_stop
branch
from
5fe06d1
to
70f1855
Compare
suquark
changed the title
|
Note: ready for review. The test failure is related to new azure-cli versions, will be fixed later |
This was referenced Feb 15, 2022
suquark
force-pushed
the
azure_start_stop
branch
from
b0a3e11
to
43a8764
Compare
|
Ready for review. |
concretevitamin
approved these changes
Feb 15, 2022
There was a problem hiding this comment.
Looks good. @Michaelvll should know more about the versioning fixes.
| @@ -197,10 +197,11 @@ def check_credentials(self) -> Tuple[bool, Optional[str]]: | |||
| # This file is required because it will be synced to remote VMs for | |||
| # `az` to access private storage buckets. | |||
| # `az account show` does not guarantee this file exists. | |||
| if not os.path.isfile(os.path.expanduser('~/.azure/accessTokens.json')): | |||
| azure_token_cache_file = '~/.azure/msal_token_cache.json' | |||
There was a problem hiding this comment.
What's the difference between:
- ~/.azure/accessTokens.json
- ~/.azure/msal_token_cache.json (sounds like a cache)?
There was a problem hiding this comment.
~/.azure/accessTokens.json is the cache for older azure-cli, ~/.azure/msal_token_cache.json is the cache for the new version
Michaelvll
approved these changes
Feb 15, 2022
Closed
gmittal
pushed a commit
that referenced
this pull request
Mar 15, 2022
* azure external node provider * allow stopping Azure * update token check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
azure-clito2.30.0. Update smoke tests.Closes #148