[Tests][BugFix] Fix invalid YAML in SkyServe smoke test w/ autoscaling #3399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaoZiming
approved these changes
Apr 1, 2024
Michaelvll
reviewed
Apr 1, 2024
| @@ -6,6 +6,7 @@ service: | |||
| min_replicas: 2 | |||
| max_replicas: 3 | |||
| base_ondemand_fallback_replicas: 1 | |||
| target_qps_per_replica: 1 | |||
There was a problem hiding this comment.
Should this be 1 or larger value? We don't expect it to scale up during the test.
|
Closed since already fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3361 we introduced new checks for the service YAML, which caused several of our smoke test failures. This PR fixes the bug.
Tested (run the relevant ones):
bash format.shsky serve upevery YAML intests/skyservefolder and make sure it workspytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_nametests/test_smoke.py::test_skyserve_dynamic_ondemand_fallbacktests/test_smoke.py::test_skyserve_base_ondemand_fallbackbash tests/backward_comaptibility_tests.sh