-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cudo] privte networks and API/fetch fix #3841
Open
JungleCatSW
wants to merge
8
commits into
skypilot-org:master
Choose a base branch
from
cudoventures:cudo-networking
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michaelvll
reviewed
Aug 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this @JungleCatSW! I am trying this PR on my Cudo account, and we get the following error:
> sky launch --cloud cudo echo hi
HTTP response headers: HTTPHeaderDict({'Date': 'Thu, 22 Aug 2024 18:52:00 GMT', 'Content-Type': 'application/json', 'Content-Length': '342', 'Connection': 'keep-alive', 'vary': 'Origin', 'CF-Cache-Status': 'DYNAMIC', 'Report-To': '{"endpoints":[{"url":"https:\\/\\/a.nel.cloudflare.com\\/report\\/v4?s=i3xfRCICUlOVn2UKCtrEGE2CXxej%2FgWhkQsfPlqrbzOkmR7cP9KXgRHRwcu5Es6Bqp00e4uDnfjIp9QK7ggwfTNYK8KDAH2tfz%2Fr3vEXClz%2FVOR%2FQNhN5VyOIUMSy%2Bbqlhv4B%2FgyFQ%3D%3D"}],"group":"cf-nel","max_age":604800}', 'NEL': '{"success_fraction":0,"report_to":"cf-nel","max_age":604800}', 'Strict-Transport-Security': 'max-age=15552000; includeSubDomains; preload', 'X-Content-Type-Options': 'nosniff', 'Server': 'cloudflare', 'CF-RAY': '8b750eb2aa8e61d1-ORD', 'alt-svc': 'h3=":443"; ma=86400'})
E 08-22 18:52:00 provisioner.py:80] HTTP response body: {"code":9,"message":"network cannot be assigned ip from public network","details":[{"@type":"type.googleapis.com/google.rpc.PreconditionFailure","violations":[{"type":"","subject":"","description":"Public network full"}]},{"@type":"type.googleapis.com/google.rpc.ErrorInfo","reason":"NETWORK_FULL","domain":"compute.cudo.org","metadata":{}}]}
@@ -11,7 +11,7 @@ | |||
|
|||
def launch(name: str, data_center_id: str, ssh_key: str, machine_type: str, | |||
memory_gib: int, vcpu_count: int, gpu_count: int, | |||
tags: Dict[str, str], disk_size: int): | |||
tags: Dict[str, str], disk_size: int, net_name): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
tags: Dict[str, str], disk_size: int, net_name): | |
tags: Dict[str, str], disk_size: int, net_name: str) -> str: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a private network so clusters can use it.
Also fixes the cudo fetcher
Our API has changed so also fixed API issues
Tested (run the relevant ones):
bash format.sh
pytest tests/test_smoke.py
pytest tests/test_smoke.py::test_fill_in_the_name
conda deactivate; bash -i tests/backward_compatibility_tests.sh