Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure] Fix azure failover with RoleAssigmentUpdateNotPermitted #3848

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented Aug 20, 2024

Fixes #3845

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

@Michaelvll Michaelvll changed the title [Azure] Fix azure failover [Azure] Fix azure failover with RoleAssigmentUpdateNotPermitted Aug 20, 2024
Copy link
Collaborator

@cblmemo cblmemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix @Michaelvll ! LGTM.

@Michaelvll Michaelvll added this pull request to the merge queue Aug 21, 2024
Merged via the queue into master with commit 2ea613f Aug 21, 2024
20 checks passed
@Michaelvll Michaelvll deleted the fix-azure-failover branch August 21, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants