Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test] Fix Smoke Test test-skyserve-fast-update #3956

Merged
merged 2 commits into from
Sep 19, 2024
Merged

[Test] Fix Smoke Test test-skyserve-fast-update #3956

merged 2 commits into from
Sep 19, 2024

Conversation

cblmemo
Copy link
Collaborator

@cblmemo cblmemo commented Sep 18, 2024 •
edited
Loading

This PR fixes a bug for smoke test test-skyserve-fast-update in latest master.

Related: #3832 (comment)

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

@cblmemo cblmemo added this pull request to the merge queue Sep 19, 2024
Merged via the queue into master with commit 3871de9 Sep 19, 2024
20 checks passed
@cblmemo cblmemo deleted the fix-serve-smoke-test-port-8081 branch September 19, 2024 19:43
@asaiacai asaiacai mentioned this pull request Sep 23, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Michaelvll Michaelvll Michaelvll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cblmemo @Michaelvll