Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WINTER watchdog: always look at the past 2 nights. #413

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

Theodlz
Copy link
Collaborator

@Theodlz Theodlz commented Aug 23, 2024

For winter since the topics are expressed in local time we already did UTC date - 1 to get the topic we want to look at.

Another issue is that at 0 UTC is when we move to new topics (when we also restart the machine every day btw), so if the WINTER alerts (that are processed and sent to IPAC manually every day, after the night of observation) are sent at or after that time, upon reboot we already are listening to the next topic and won't read the data from the previous night.

So in this PR, we just make the obsdate parameter a list (obsdates), which defaults to not just UTC -1, but UTC -1 AND UTC -2.

We could consider looking back a third day just to be safe, might want to just make that configurable at some point.

@robertdstein
Copy link
Contributor

FYI WINTER alerts are not sent manually to IPAC each day. They are sent to IPAC as the final step in our automated DRP, similar to ZTF, but our processing time for a given night can vary substantially and we currently process the entire night sequentially rather than image-by-image. The upshot is that if we observe a lot of the galactic plane, processing can last beyond the cutoff time for Kowalski.

Copy link
Contributor

@robertdstein robertdstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Theodlz
Copy link
Collaborator Author

Theodlz commented Aug 23, 2024

FYI WINTER alerts are not sent manually to IPAC each day. They are sent to IPAC as the final step in our automated DRP, similar to ZTF, but our processing time for a given night can vary substantially and we currently process the entire night sequentially rather than image-by-image. The upshot is that if we observe a lot of the galactic plane, processing can last beyond the cutoff time for Kowalski.

Oh cool! I remembered that this was not fully automated earlier on, is that correct?

@Theodlz
Copy link
Collaborator Author

Theodlz commented Aug 23, 2024

FYI WINTER alerts are not sent manually to IPAC each day. They are sent to IPAC as the final step in our automated DRP, similar to ZTF, but our processing time for a given night can vary substantially and we currently process the entire night sequentially rather than image-by-image. The upshot is that if we observe a lot of the galactic plane, processing can last beyond the cutoff time for Kowalski.

Oh cool! I remembered that this was not fully automated earlier on, is that correct?

Or rather, that you guys had to wait before running the fully automated pipeline

@Theodlz Theodlz merged commit 77f5cd3 into skyportal:main Aug 23, 2024
3 checks passed
@robertdstein
Copy link
Contributor

It starts at a fixed time every day, rather than processing data in real time.

We do also have the option to push candidates in manually via the API, maybe that's the source of confusion? But that only gets used if we need to reprocess data, it's a few times a year that it gets used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants