Run all the integration tests - 2024-07-01 PT

slackapi · Jul 2, 2024 · 2ae1fa3 · 2ae1fa3
1 parent e1b7a42
commit 2ae1fa3
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 16 deletions.
diff --git a/json-logs/samples/api/files.completeUploadExternal.json b/json-logs/samples/api/files.completeUploadExternal.json
@@ -94,7 +94,8 @@
         }
       },
       "channels": [
-        "C00000000"
+        "C00000000",
+        ""
       ],
       "groups": [
         ""

diff --git a/json-logs/samples/api/users.discoverableContacts.lookup.json b/json-logs/samples/api/users.discoverableContacts.lookup.json
@@ -3,12 +3,10 @@
   "error": "",
   "needed": "",
   "provided": "",
-  "user": {
-    "is_discoverable": false
-  },
   "response_metadata": {
     "messages": [
       ""
     ]
-  }
+  },
+  "is_discoverable": false
 }
diff --git a/...methods/response/users/discoverable_contacts/UsersDiscoverableContactsLookupResponse.java b/...methods/response/users/discoverable_contacts/UsersDiscoverableContactsLookupResponse.java
@@ -1,6 +1,5 @@
 package com.slack.api.methods.response.users.discoverable_contacts;
 
-import com.google.gson.annotations.SerializedName;
 import com.slack.api.methods.SlackApiTextResponse;
 import com.slack.api.model.ResponseMetadata;
 import lombok.Data;
@@ -18,13 +17,6 @@ public class UsersDiscoverableContactsLookupResponse implements SlackApiTextResp
     private String provided;
     private transient Map<String, List<String>> httpResponseHeaders;
 
-    private UserContact user;
-
+    private Boolean isDiscoverable;
     private ResponseMetadata responseMetadata;
-
-    @Data
-    public static class UserContact {
-        @SerializedName("is_discoverable")
-        private boolean discoverable;
-    }
 }
diff --git a/slack-api-client/src/test/java/test_with_remote_apis/methods/users_Test.java b/slack-api-client/src/test/java/test_with_remote_apis/methods/users_Test.java
@@ -451,8 +451,7 @@ public void discoverableContacts() throws Exception {
         String email = user.getUser().getProfile().getEmail();
         UsersDiscoverableContactsLookupResponse response = slack.methods(orgBotToken)
                 .usersDiscoverableContactsLookup(r -> r.email(email));
-        // TODO: valid tests
-        assertThat(response.getError(), is("not_allowed"));
+        assertThat(response.getError(), is(nullValue()));
     }
 
     @Test