Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint: enforce max line length / max items per line / one item per line for imports using import-newlines eslint plugin #1730

Merged
merged 1 commit into from
Jan 19, 2024
Merged

lint: enforce max line length / max items per line / one item per line for imports using import-newlines eslint plugin #1730

merged 1 commit into from
Jan 19, 2024

Conversation

filmaj
Copy link
Contributor

@filmaj filmaj commented Jan 18, 2024

A majority of the changes in here are style changes introduced by enforcing import line styles using eslint-plugin-import-newlines.

For reviewers: just need to check changes to .eslintrc.js. You can see the impact this change has on the import style in the rest of the changes.

@filmaj
lint: enforce max line length / max items per line / one item per lin…
46185c5 
…e for imports using import-newlines eslint plugin.
@filmaj filmaj added semver:patch tests M-T: Testing work only pkg:web-api applies to `@slack/web-api` pkg:rtm-api applies to `@slack/rtm-api` pkg:webhook applies to `@slack/webhook` pkg:logger applies to `@slack/logger` pkg:types applies to `@slack/types` pkg:oauth applies to `@slack/oauth-helper` pkg:socket-mode applies to `@slack/socket-mode` labels Jan 18, 2024
@filmaj filmaj requested a review from zimeg January 18, 2024 21:31
@filmaj filmaj self-assigned this Jan 18, 2024
zimeg
zimeg approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L
G
T
M
😄

@filmaj filmaj merged commit 99b939a into main Jan 19, 2024
15 checks passed
@filmaj filmaj deleted the lint-enforce-import-newlines branch January 19, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimeg zimeg zimeg approved these changes

Assignees

@filmaj filmaj

Labels
pkg:logger applies to `@slack/logger` pkg:oauth applies to `@slack/oauth-helper` pkg:rtm-api applies to `@slack/rtm-api` pkg:socket-mode applies to `@slack/socket-mode` pkg:types applies to `@slack/types` pkg:web-api applies to `@slack/web-api` pkg:webhook applies to `@slack/webhook` semver:patch tests M-T: Testing work only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filmaj @zimeg