Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vtgate] Backport vitessio/vitess#11167 #10

Merged

Conversation

brirams
Copy link

@brirams brirams commented Sep 27, 2022

Motivation

As the title suggests, this is a backport of a change that was made in upstream change for the v15 release.

Changes

Most all changes there were applied to our v12 branch except for:

  • changes to the endtoend flags tests(they don't exist in v12)
  • changes to the v15 changelog(obviously doesn't exist in v12)

Testing

  • new benchmark tests added
  • some unit tests pass(most end up being marked as flaky in future release)
  • deployed this to dev and started up as expected with the new flag off and on

Signed-off-by: Brian Ramos <brirams@users.noreply.github.com>
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@brirams brirams merged commit a6fd374 into slack-vitess-r12.0.5 Sep 29, 2022
@tanjinx tanjinx added the v12 label Dec 9, 2022
@tanjinx tanjinx added the enhancement New feature or request label Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v12
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants