Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: exclude codeql on yaml #1008

Merged
merged 12 commits into from
Oct 18, 2022
Merged

Conversation

asraa
Copy link
Collaborator

@asraa asraa commented Oct 13, 2022

@asraa asraa marked this pull request as ready for review October 13, 2022 20:40
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
.github/workflows/codeql-analysis.yml Outdated Show resolved Hide resolved
Signed-off-by: Asra Ali <asraa@google.com>
@asraa
Copy link
Collaborator Author

asraa commented Oct 13, 2022

CodeQL Expected — Waiting for status to be reported

TBD I'll make a skipping job or figure out something else.

Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
@asraa
Copy link
Collaborator Author

asraa commented Oct 14, 2022

Updated because GitHub recommends creating a duplicate workflow with the same name and job that runs on the ignored paths and performs a successful noop

.github/workflows/codeql-analysis-noop.yml Outdated Show resolved Hide resolved
.github/workflows/codeql-analysis-noop.yml Show resolved Hide resolved
@ianlewis
Copy link
Member

ianlewis commented Oct 18, 2022

@asraa I removed CodeQL as a required check. After this is merged we can hopefully add "CodeQL / Analyze" to the required checks on the protected branch rules.

#1047 (comment)

@asraa asraa merged commit 1f9352c into slsa-framework:main Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Disable CodeQL for changes only on YAML
2 participants