fix: add source to container-based predicate's resolveddependencies & fix internalParams #2183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ource dep Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
We can do that, but is that too brittle? the resolved dependencies is explicitly supposed to be an unordered collection according to slsa spec. |
Signed-off-by: Asra Ali <asraa@google.com> revert script Signed-off-by: Asra Ali <asraa@google.com>
asraa
changed the title
|
Per resolution offline, let's keep uniformly as first resolvedDeps until we have a universal solution. |
laurentsimon
approved these changes
May 27, 2023
laurentsimon
pushed a commit
to laurentsimon/slsa-github-generator
that referenced
this pull request
Jun 1, 2023
… fix internalParams (slsa-framework#2183) Fixes slsa-framework#2182 This ensures that the source dependency comes first in the list of resolved dependencies. This way, the verifier can identify the correct source. This will fix the container based e2e tests. Also took the opportunity to clean up the predicate's internal paremeters - no more github runner or other invalid fields. --------- Signed-off-by: Asra Ali <asraa@google.com> Signed-off-by: laurentsimon <laurentsimon@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2182
This ensures that the source dependency comes first in the list of resolved dependencies. This way, the verifier can identify the correct source.
This will fix the container based e2e tests.
Also took the opportunity to clean up the predicate's internal paremeters - no more github runner or other invalid fields.