Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy env vars #616

Merged
merged 2 commits into from
Jul 25, 2022
Merged

Remove legacy env vars #616

merged 2 commits into from
Jul 25, 2022

Conversation

ianlewis
Copy link
Member

@ianlewis ianlewis commented Jul 22, 2022 •
edited
Loading

Fixes #613

This PR removes legacy env vars from the container workflow. These environment variables were previously used by the scripts that are now part of the generate-builder action when the script was invoked directly by the workflow itself.

laurentsimon
laurentsimon approved these changes Jul 22, 2022
View reviewed changes
Copy link
Collaborator

@laurentsimon laurentsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ianlewis ianlewis marked this pull request as ready for review July 25, 2022 00:54
@ianlewis ianlewis enabled auto-merge (squash) July 25, 2022 01:54
@ianlewis ianlewis merged commit 575bdd2 into slsa-framework:main Jul 25, 2022
@ianlewis ianlewis deleted the 613-refactor-clean-up-env-vars branch July 27, 2022 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurentsimon laurentsimon laurentsimon approved these changes

@asraa asraa Awaiting requested review from asraa

@joshuagl joshuagl Awaiting requested review from joshuagl joshuagl is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[refactor] Clean up env vars
2 participants
@ianlewis @laurentsimon