Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily disable Run test. #772

Merged
merged 2 commits into from
Aug 30, 2022
Merged

Temporarily disable Run test. #772

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f560e4f
Temporarily disable Run test.
ianlewis Aug 29, 2022
fe969f5
Merge branch 'main' into fix-tests-exec
ianlewis Aug 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
236 changes: 118 additions & 118 deletions internal/builders/go/pkg/build_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ package pkg
import (
"fmt"
"os"
"os/exec"
"testing"

"github.com/google/go-cmp/cmp"
Expand Down Expand Up @@ -1049,120 +1048,121 @@ func asPointer(s string) *string {
return &s
}

func TestGoBuild_Run(t *testing.T) {
type fields struct {
cfg *GoReleaserConfig
goc string
argEnv map[string]string
}
type args struct {
dry bool
}
tests := []struct {
name string
fields fields
args args
wantErr bool
err error
}{
{
name: "dry run valid flags",
fields: fields{
cfg: &GoReleaserConfig{
Goos: "linux",
Goarch: "amd64",
Binary: "binary",
Main: asPointer("../builders/go/main.go"),
Dir: asPointer("../builders/go"),
Ldflags: []string{
"-X main.version=1.0.0",
},
},
},
args: args{
dry: true,
},
},
{
name: "non-dry valid flags",
fields: fields{
cfg: &GoReleaserConfig{
Goos: "linux",
Goarch: "amd64",
Binary: "/tmp/binary",
Main: asPointer("main.go"),
Dir: asPointer("./testdata/go"),
Ldflags: []string{
"-X main.version=1.0.0",
},
},
},
args: args{
dry: false,
},
},
{
name: "slash in the binary name",
fields: fields{
cfg: &GoReleaserConfig{
Goos: "linux",
Goarch: "amd64",
Binary: "tmp/binary",
Main: asPointer("../builders/go/main.go"),
Dir: asPointer("../builders/go"),
},
},
args: args{
dry: true,
},
wantErr: true,
err: errorInvalidFilename,
},
{
name: "dry run - invalid flags",
fields: fields{
cfg: &GoReleaserConfig{
Goos: "linux",
Goarch: "amd64",
Binary: "binary",
Main: asPointer("../builders/go/main.go"),
Dir: asPointer("../builders/go"),
Ldflags: []string{},
},
},
args: args{
dry: true,
},
wantErr: false,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
b := &GoBuild{
cfg: tt.fields.cfg,
goc: tt.fields.goc,
argEnv: tt.fields.argEnv,
}
t.Setenv("OUTPUT_BINARY", tt.fields.cfg.Binary)
// if the test is not dry run , then code has to look for golang binary
if !tt.args.dry {
path, err := exec.LookPath("go")
if err != nil {
t.Errorf("exec.LookPath: %v", err)
}
b.goc = path
}
err := b.Run(tt.args.dry)
if err != nil != tt.wantErr {
t.Errorf("Run() error = %v, wantErr %v", err, tt.wantErr)
}
if tt.err != nil {
if err == nil {
t.Errorf("Run() error = nil, wantErr %v", tt.err)
} else if errCmp(err, tt.err) {
t.Errorf("Run() error = %v, wantErr %v %v", err, tt.err, cmp.Diff(err, tt.err))
}
}
})
}
}
// TODO(https://github.com/slsa-framework/slsa-github-generator/issues/771): reinstate test
// func TestGoBuild_Run(t *testing.T) {
// type fields struct {
// cfg *GoReleaserConfig
// goc string
// argEnv map[string]string
// }
// type args struct {
// dry bool
// }
// tests := []struct {
// name string
// fields fields
// args args
// wantErr bool
// err error
// }{
// {
// name: "dry run valid flags",
// fields: fields{
// cfg: &GoReleaserConfig{
// Goos: "linux",
// Goarch: "amd64",
// Binary: "binary",
// Main: asPointer("../builders/go/main.go"),
// Dir: asPointer("../builders/go"),
// Ldflags: []string{
// "-X main.version=1.0.0",
// },
// },
// },
// args: args{
// dry: true,
// },
// },
// {
// name: "non-dry valid flags",
// fields: fields{
// cfg: &GoReleaserConfig{
// Goos: "linux",
// Goarch: "amd64",
// Binary: "/tmp/binary",
// Main: asPointer("main.go"),
// Dir: asPointer("./testdata/go"),
// Ldflags: []string{
// "-X main.version=1.0.0",
// },
// },
// },
// args: args{
// dry: false,
// },
// },
// {
// name: "slash in the binary name",
// fields: fields{
// cfg: &GoReleaserConfig{
// Goos: "linux",
// Goarch: "amd64",
// Binary: "tmp/binary",
// Main: asPointer("../builders/go/main.go"),
// Dir: asPointer("../builders/go"),
// },
// },
// args: args{
// dry: true,
// },
// wantErr: true,
// err: errorInvalidFilename,
// },
// {
// name: "dry run - invalid flags",
// fields: fields{
// cfg: &GoReleaserConfig{
// Goos: "linux",
// Goarch: "amd64",
// Binary: "binary",
// Main: asPointer("../builders/go/main.go"),
// Dir: asPointer("../builders/go"),
// Ldflags: []string{},
// },
// },
// args: args{
// dry: true,
// },
// wantErr: false,
// },
// }
// for _, tt := range tests {
// t.Run(tt.name, func(t *testing.T) {
// b := &GoBuild{
// cfg: tt.fields.cfg,
// goc: tt.fields.goc,
// argEnv: tt.fields.argEnv,
// }
// t.Setenv("OUTPUT_BINARY", tt.fields.cfg.Binary)
// // if the test is not dry run , then code has to look for golang binary
// if !tt.args.dry {
// path, err := exec.LookPath("go")
// if err != nil {
// t.Errorf("exec.LookPath: %v", err)
// }
// b.goc = path
// }
// err := b.Run(tt.args.dry)
// if err != nil != tt.wantErr {
// t.Errorf("Run() error = %v, wantErr %v", err, tt.wantErr)
// }
// if tt.err != nil {
// if err == nil {
// t.Errorf("Run() error = nil, wantErr %v", tt.err)
// } else if errCmp(err, tt.err) {
// t.Errorf("Run() error = %v, wantErr %v %v", err, tt.err, cmp.Diff(err, tt.err))
// }
// }
// })
// }
// }