Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: version command is empty #391

Closed
laurentsimon opened this issue Dec 6, 2022 · 1 comment · Fixed by #392
Closed

bug: version command is empty #391

laurentsimon opened this issue Dec 6, 2022 · 1 comment · Fixed by #392

Comments

@laurentsimon
Copy link
Contributor

laurentsimon commented Dec 6, 2022 •
edited
Loading

For v2.0.0:

$ ./slsa-verifier-linux-amd64 version
...
GitVersion:    
GitCommit:     128324f48837d274fdb69870704477a8d2645b8d

This will also be helpful to validate we install the correct verifier in our Action installer.
Let's also add this to our post-release checks in the RELEASE.md

/cc @asraa
@laurentsimon laurentsimon mentioned this issue Dec 6, 2022
Merged
@laurentsimon
Copy link
Contributor Author

Can we include this fix i our next release?

@asraa asraa closed this as completed in #392 Dec 6, 2022
ramonpetgrave64 pushed a commit to ramonpetgrave64/slsa-verifier that referenced this issue Apr 18, 2024
@naveensrinivasan @laurentsimon
Option to configure rekor server. (slsa-framework#391)
c206bf3 
* Option to configure rekor server.

- Provided an option to configure the rekor server.
- Fixes slsa-framework/slsa-github-generator#372

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>

* mend

Co-authored-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: show version in version command laurentsimon/slsa-verifier
1 participant
@laurentsimon