Verify text provenance for GCB #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentsimon
commented
Aug 30, 2022
| @@ -0,0 +1,684 @@ | |||
| package gcb | |||
|
|
|||
| import ( | |||
There was a problem hiding this comment.
For some reason this file was not committed but should have in a previous PR.
laurentsimon
commented
Aug 30, 2022
| } | ||
| } | ||
|
|
||
| func Test_VerifyTextProvenance(t *testing.T) { |
There was a problem hiding this comment.
This is the additional test for this PR.
asraa
reviewed
Aug 30, 2022
asraa
approved these changes
Aug 30, 2022
| // The GCB provenance contains a human-readable version of the intoto | ||
| // statement, but it is not compliant with the standard. It uses `slsaProvenance` | ||
| // instead of `predicate`. For backward compatibility, this has not been fixed | ||
| // by the GCB team. |
There was a problem hiding this comment.
thanks for the note! was confused about why not use an intotostatement
asraa
reviewed
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCB has an additional text human-readable version of the DSSE payload. This PR verifiers that it matches the verified DSSE payload.