Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix comment typos #244

Merged
merged 1 commit into from
Sep 1, 2022
Merged

doc: fix comment typos #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions verifiers/internal/gcb/provenance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,8 +175,8 @@ func (self *Provenance) VerifyTextProvenance() error {
}

// Note: DeepEqual() has problem with time comparisons: https://github.com/onsi/gomega/issues/264
// but this should not affect us since both times are supposed to have the the same string and
// they are both taken from a strng representation.
// but this should not affect us since both times are supposed to have the same string and
// they are both taken from a string representation.
// We do not use cmp.Equal() because it *can* panic and is intended for unit tests only.
if !reflect.DeepEqual(unverifiedTextIntotoStatement, *self.verifiedIntotoStatement) {
return fmt.Errorf("%w: diff '%s'", serrors.ErrorMismatchIntoto,
Expand Down
4 changes: 2 additions & 2 deletions verifiers/internal/gcb/provenance_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,8 +521,8 @@ func Test_VerifyTextProvenance(t *testing.T) {
}

if err = json.Unmarshal(patch, &prov.verifiedProvenance.Build.UnverifiedTextIntotoStatement); err != nil {
// If we updated a characters that make a non-string fiel invalid, like Time, unmarshalin will fail,
// and we ignore the error.
// If we updated a character that makes a non-string field invalid, like Time, unmarshaling will fail,
// so we ignore the error.
i += 1
patch = []byte(strings.Clone(string(cpy)))
continue
Expand Down