gcb: add gcb compatibility for provenance formats and buckets #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Asra Ali <asraa@google.com>
asraa
force-pushed
the
add-gcb-compatibility
branch
from
9f17aab
to
dcb49d5
Compare
inferno-chromium
approved these changes
Oct 7, 2022
ianlewis
reviewed
Oct 10, 2022
| Type string `json:"type"` | ||
| // DefinedInMaterial can be sent as the null pointer to indicate that | ||
| // the value is not present. | ||
| // DefinedInMaterial *int `json:"definedInMaterial,omitempty"` |
There was a problem hiding this comment.
nit: add a short local comment as to why this is commented out. Maybe point to comment at top of file.
| @@ -0,0 +1,68 @@ | |||
| package gcb | |||
|
|
|||
| // Copy of github.com/in-toto/in-toto-golang/in_toto/slsa_provenance/v0.1 | |||
There was a problem hiding this comment.
nit: add a "NOTE: " prefix to the comment.
| if !strings.HasPrefix(expectedSourceURI, "https://") { | ||
|
|
||
| // It is possible that GCS builds at level 2 use GCS sources, prefixed by gs://. | ||
| if strings.HasPrefix(uri, "https://") && !strings.HasPrefix(expectedSourceURI, "https://") { |
There was a problem hiding this comment.
nit: You might also leave a note as to why this is necessary in the first place. It's not necessarily obvious why "https://" might need to be prefixed at the beginning.
There was a problem hiding this comment.
Also, consider checking for any URI scheme rather than "https://" specifically. So you don't end up with strange URIs like "https://http://example.com/..." if the user enters "--source http://example.com"
Suggested change
| if strings.HasPrefix(uri, "https://") && !strings.HasPrefix(expectedSourceURI, "https://") { | |
| if strings.HasPrefix(uri, "https://") && !strings.HasPrefix(expectedSourceURI, "://") { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Asra Ali asraa@google.com
This PR does two things in order to achieve GCB provenance compatibility:
definedInMaterialfield. Until GCB updates their provenance generation, this will have to do.v0.3does not necessarily produce level 3 provenance, and we can only guarantee the provenance requirements (up to non-falsifiability for v0.3). We should definitely prioritize a versioning option in the future that would disallow generating provenance in a lower level mannger.Adds testcase for the JSON marshalling issue and the GCS Buckets.