Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix builder id matching #308

Merged
merged 3 commits into from
Oct 18, 2022
Merged

tests: fix builder id matching #308

merged 3 commits into from
Oct 18, 2022

Conversation

asraa
Copy link
Contributor

@asraa asraa commented Oct 17, 2022

Signed-off-by: Asra Ali asraa@google.com

There seems to have been an error where when checking various forms of builder IDs, the loop would return rather than check all builder IDs for the test.

Unfortunately, this breaks some tests:

  1. The multi-subjects were generated at main, not be a particular version. So moved those to noversion: true. If we want to regression test this behavior at each version, I can change that later.
  2. The builder ID without the qualified /refs/tags/VERSION, just VERSION does not succeed the Match behvaior.

Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
@asraa
Copy link
Contributor Author

asraa commented Oct 18, 2022

Merging, @laurentsimon let me know if the intent was to verify builders against https://github.com/slsa-framework/slsa-github-generator/.github/workflows/generator_generic_slsa3.yml@v1.0.0. I think it was, but some things are broken. I'll investigate

@asraa
Copy link
Contributor Author

asraa commented Oct 18, 2022

EDIT: It does work on the CLI; something it just broken with tests.

@asraa asraa merged commit 6766be3 into slsa-framework:main Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants