docs: refer v2.0.0 in README #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shunsuke Suzuki <suzuki.shunsuke.1989@gmail.com>
suzuki-shunsuke
changed the title
|
#373 has been merged. So this pr is ready. |
laurentsimon
approved these changes
Dec 2, 2022
suzuki-shunsuke
commented
Dec 2, 2022
| @@ -120,21 +120,21 @@ You have two options to install the verifier. | |||
| #### Option 1: Install via go | |||
|
|
|||
| ``` | |||
| $ go install github.com/slsa-framework/slsa-verifier/cli/slsa-verifier@v1.3.2 | |||
| $ go install github.com/slsa-framework/slsa-verifier/v2/cli/slsa-verifier@v2.0.0 | |||
There was a problem hiding this comment.
Oh, sorry. I found this doesn't work. 🙇♂️
To install slsa-verifier v2 by go install, we have to release v2.0.1 or later.
go install github.com/slsa-framework/slsa-verifier/v2/cli/slsa-verifier@v2.0.0
go: github.com/slsa-framework/slsa-verifier/v2/cli/slsa-verifier@v2.0.0: github.com/slsa-framework/slsa-verifier@v2.0.0: invalid version: module contains a go.mod file, so module path must match major version ("github.com/slsa-framework/slsa-verifier/v2")I'll send a pull request to fix the document.
There was a problem hiding this comment.
Created the pr.
Merged
asraa
pushed a commit
that referenced
this pull request
Dec 2, 2022
#375 (comment) I found this doesn't work. To install slsa-verifier v2 by go install, we have to release v2.0.1 or later. ``` go install github.com/slsa-framework/slsa-verifier/v2/cli/slsa-verifier@v2.0.0 go: github.com/slsa-framework/slsa-verifier/v2/cli/slsa-verifier@v2.0.0: github.com/slsa-framework/slsa-verifier@v2.0.0: invalid version: module contains a go.mod file, so module path must match major version ("github.com/slsa-framework/slsa-verifier/v2") ``` Signed-off-by: Shunsuke Suzuki <suzuki.shunsuke.1989@gmail.com> Signed-off-by: Shunsuke Suzuki <suzuki.shunsuke.1989@gmail.com>
ramonpetgrave64
pushed a commit
to ramonpetgrave64/slsa-verifier
that referenced
this pull request
Apr 18, 2024
* updates * updates Co-authored-by: asraa <asraa@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #373