Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add comment for signature decoding #380

Merged
merged 3 commits into from
Dec 2, 2022

Conversation

laurentsimon
Copy link
Contributor

closes #377

We perform both std and URL base64 decoding, so adding a comment why.

verifiers/internal/gcb/provenance.go Outdated Show resolved Hide resolved
@asraa asraa changed the title doc: Add comment for signature decoding docs: Add comment for signature decoding Dec 2, 2022
laurentsimon and others added 2 commits December 2, 2022 18:09
Signed-off-by: laurentsimon <laurentsimon@google.com>
Co-authored-by: asraa <asraa@google.com>
Signed-off-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com>
Signed-off-by: laurentsimon <laurentsimon@google.com>
@laurentsimon laurentsimon merged commit b9058c5 into slsa-framework:main Dec 2, 2022
ramonpetgrave64 pushed a commit to ramonpetgrave64/slsa-verifier that referenced this pull request Apr 18, 2024
…-framework#380)

Bumps [slsa-framework/slsa-github-generator](https://github.com/slsa-framework/slsa-github-generator) from 1.0.0 to 1.1.1.
- [Release notes](https://github.com/slsa-framework/slsa-github-generator/releases)
- [Changelog](https://github.com/slsa-framework/slsa-github-generator/blob/main/RELEASE.md)
- [Commits](slsa-framework/slsa-github-generator@bbeae84...d995948)

---
updated-dependencies:
- dependency-name: slsa-framework/slsa-github-generator
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible code duplication
2 participants