Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix error check for decodeSignature #385

Merged
merged 1 commit into from
Dec 3, 2022
Merged

fix: Fix error check for decodeSignature #385

merged 1 commit into from
Dec 3, 2022

Conversation

ianlewis
Copy link
Member

@ianlewis ianlewis commented Dec 3, 2022

Updates #377

Signed-off-by: Ian Lewis ianmlewis@gmail.com

@ianlewis
fix: Fix error check for decodeSignature
a97cf82 
Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
laurentsimon
laurentsimon approved these changes Dec 3, 2022
View reviewed changes
Copy link
Contributor

@laurentsimon laurentsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks!

If decodeSignature failed, we'd still be catching an error in VerifySignature(), so this should not be a vulnerability. We'd be missing some errors when report to the user.

Please confirm we have the same understanding.

@laurentsimon laurentsimon merged commit 267242e into slsa-framework:main Dec 3, 2022
@ianlewis
Copy link
Member Author

ianlewis commented Dec 5, 2022

Great catch, thanks!

If decodeSignature failed, we'd still be catching an error in VerifySignature(), so this should not be a vulnerability. We'd be missing some errors when report to the user.

Please confirm we have the same understanding.

Yes I think that's right. We would have just been discarding the actual errors returned by decodeSignature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurentsimon laurentsimon laurentsimon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ianlewis @laurentsimon