Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show version in version command #392

Merged
merged 3 commits into from
Dec 6, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ jobs:
echo "::set-output name=version::$(git describe --tags --always --dirty | cut -c2-)"

builder:
needs: [args]
permissions:
actions: read # For the detection of GitHub Actions environment.
id-token: write # For signing.
Expand Down
4 changes: 4 additions & 0 deletions RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@ Check the following:
1. Ensure that the release is successful and provenance can be verified properly.
2. Either manually trigger or wait for a nightly scheduled run of all [example-package e2e tests](https://github.com/slsa-framework/example-package/tree/main/.github/workflows) and ensure that all tests are passing.
3. Ensure that the latest release can be installed via a `go install`.
4. Verify that the version reported by the `version` command is correct:
```shell
$ ./slsa-verifier version 2>&1 | grep GitVersion
```

If both of these steps succeed, then move on to the [Final Release](#final-release).

Expand Down
3 changes: 2 additions & 1 deletion actions/installer/dist/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,8 @@ function cleanup() {
}
function run() {
return __awaiter(this, void 0, void 0, function* () {
// Get requested verifier version and validate
// Get requested verifier version and validate.
// See https://docs.github.com/en/actions/learn-github-actions/contexts#github-context.
const actionRef = process.env.GITHUB_ACTION_REF || "";
let version;
try {
Expand Down
2 changes: 1 addition & 1 deletion actions/installer/dist/index.js.map

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion actions/installer/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,8 @@ async function cleanup(): Promise<void> {
}

async function run(): Promise<void> {
// Get requested verifier version and validate
// Get requested verifier version and validate.
// See https://docs.github.com/en/actions/learn-github-actions/contexts#github-context.
const actionRef = process.env.GITHUB_ACTION_REF || "";
let version: string;
try {
Expand Down