feat: support for BYOB verification #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianlewis
approved these changes
Apr 19, 2023
verifiers/internal/gha/npm.go
Outdated
| @@ -21,6 +21,8 @@ import ( | |||
|
|
|||
| const ( | |||
| publishAttestationV01 = "https://github.com/npm/attestation/tree/main/specs/publish/" | |||
| builderGitHubRunnerID = "https://github.com/actions/runner" | |||
| ossfNpmBuilderID = "https://github.com/slsa-framework/slsa-github-generator/.github/workflows/builder_nodejs_slsa3.yml" | |||
There was a problem hiding this comment.
I guess you don't actually need this anymore since the builder-id option is required?
There was a problem hiding this comment.
Good catch. You're correct, I'll remove it.
Co-authored-by: Ian Lewis <ianlewis@google.com> Signed-off-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com>
laurentsimon
force-pushed
the
feat/byob-verification
branch
from
4ce0614
to
aec33dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLI tests will need to be added once we have a non RC release.
I have made the builder-id a mandatory option, to ensure there is no bias towards GitHub as default trusted builders.
Will need a follow-up PR to add exception to allow certain workflows to be referenced at main for testing.