Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Non-compulsory BuilderID for BYOB Builders #674

Merged
merged 42 commits into from
Aug 11, 2023
Merged

feat: Non-compulsory BuilderID for BYOB Builders #674

merged 42 commits into from
Aug 11, 2023

Commits on Jul 31, 2023

  1. Squash commits from byob patch 

    Signed-off-by: Noah Elzner <elzner@google.com>
    @enteraga6
    enteraga6 committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    646a3ad View commit details
    Browse the repository at this point in the history

  2. improve error message and comments 

    Signed-off-by: Noah Elzner <elzner@google.com>
    @enteraga6
    enteraga6 committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    fa2148a View commit details
    Browse the repository at this point in the history

  3. Improvements 

    Signed-off-by: Noah Elzner <elzner@google.com>
    @enteraga6
    enteraga6 committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    ebf4ffc View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Fixed logic and comments from review feedback 

    Signed-off-by: Noah Elzner <elzner@google.com>
    @enteraga6
    enteraga6 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    67c29de View commit details
    Browse the repository at this point in the history

  2. changed scope of comment 

    Signed-off-by: Noah Elzner <elzner@google.com>
    @enteraga6
    enteraga6 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    38ce418 View commit details
    Browse the repository at this point in the history

  3. Improved function description 

    Signed-off-by: Noah Elzner <elzner@google.com>
    @enteraga6
    enteraga6 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    03b26a6 View commit details
    Browse the repository at this point in the history

  4. condense comment 

    Signed-off-by: Noah Elzner <elzner@google.com>
    @enteraga6
    enteraga6 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    1095060 View commit details
    Browse the repository at this point in the history

  5. space nit 

    Signed-off-by: Noah Elzner <elzner@google.com>
    @enteraga6
    enteraga6 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    acac0b8 View commit details
    Browse the repository at this point in the history

  6. nit: end sentence with period 

    Signed-off-by: Noah Elzner <elzner@google.com>
    @enteraga6
    enteraga6 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    fd17c7d View commit details
    Browse the repository at this point in the history

  7. Fix function and improve comment on conditional logic 

    Signed-off-by: Noah Elzner <elzner@google.com>
    @enteraga6
    enteraga6 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    eb104b8 View commit details
    Browse the repository at this point in the history

  8. Use builder.go vars for trusted builder string 

    Signed-off-by: Noah Elzner <elzner@google.com>
    @enteraga6
    enteraga6 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    c974544 View commit details
    Browse the repository at this point in the history

  9. comment fix 

    Signed-off-by: Noah Elzner <elzner@google.com>
    @enteraga6
    enteraga6 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    9318f88 View commit details
    Browse the repository at this point in the history

  10. moved comment to caller for better understanding 

    Signed-off-by: Noah Elzner <elzner@google.com>
    @enteraga6
    enteraga6 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    ae63dee View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. nit: start doc comments with the name of the function as if it was pu… 

    …blic.

Co-authored-by: Ian Lewis <ianlewis@google.com>
Signed-off-by: Noah Elzner <78953604+enteraga6@users.noreply.github.com>
    @enteraga6 @ianlewis
    enteraga6 and ianlewis committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    f00ae0d View commit details
    Browse the repository at this point in the history

  2. nit: builderIDPath --> builderIDPathPrefix 

    Signed-off-by: Noah Elzner <78953604+enteraga6@users.noreply.github.com>
    @enteraga6
    enteraga6 committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    42d475e View commit details
    Browse the repository at this point in the history

  3. nit: pass in only expectedID instead of entire builderOpts 

    Signed-off-by: Noah Elzner <78953604+enteraga6@users.noreply.github.com>
    @enteraga6
    enteraga6 committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    90aa32a View commit details
    Browse the repository at this point in the history

  4. nit: only pass in builderOpts.ExpectedID 

    Signed-off-by: Noah Elzner <78953604+enteraga6@users.noreply.github.com>
    @enteraga6
    enteraga6 committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    2301ade View commit details
    Browse the repository at this point in the history

  5. nit: fix off comment 

    Signed-off-by: Noah Elzner <78953604+enteraga6@users.noreply.github.com>
    @enteraga6
    enteraga6 committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    996892d View commit details
    Browse the repository at this point in the history

  6. nit: inputted 

    Co-authored-by: Ian Lewis <ianlewis@google.com>
Signed-off-by: Noah Elzner <78953604+enteraga6@users.noreply.github.com>
    @enteraga6 @ianlewis
    enteraga6 and ianlewis committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    217f027 View commit details
    Browse the repository at this point in the history

  7. nit: inputted 

    Co-authored-by: Ian Lewis <ianlewis@google.com>
Signed-off-by: Noah Elzner <78953604+enteraga6@users.noreply.github.com>
    @enteraga6 @ianlewis
    enteraga6 and ianlewis committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    78e971e View commit details
    Browse the repository at this point in the history

  8. nit: note --> NOTE 

    Co-authored-by: Ian Lewis <ianlewis@google.com>
Signed-off-by: Noah Elzner <78953604+enteraga6@users.noreply.github.com>
    @enteraga6 @ianlewis
    enteraga6 and ianlewis committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    c214062 View commit details
    Browse the repository at this point in the history

  9. style: remove else block 

    Signed-off-by: Noah Elzner <elzner@google.com>
    @enteraga6
    enteraga6 committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    dc80287 View commit details
    Browse the repository at this point in the history

  10. nit: un-needed usage case for --builder-id 

    Signed-off-by: Noah Elzner <78953604+enteraga6@users.noreply.github.com>
    @enteraga6
    enteraga6 committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    5245b53 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. Merge branch 'slsa-framework:main' into byob-builder-feat

    @enteraga6
    enteraga6 committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    5c944e6 View commit details
    Browse the repository at this point in the history

  2. trusted builder test case added 

    Signed-off-by: Noah Elzner <elzner@google.com>
    @enteraga6
    enteraga6 committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    d03a11e View commit details
    Browse the repository at this point in the history

  3. Added test case for untrusted builder 

    Signed-off-by: Noah Elzner <elzner@google.com>
    @enteraga6
    enteraga6 committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    0118fea View commit details
    Browse the repository at this point in the history

  4. lint 

    Signed-off-by: Noah Elzner <elzner@google.com>
    @enteraga6
    enteraga6 committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    4209ffe View commit details
    Browse the repository at this point in the history

  5. explicity set id to nil 

    Co-authored-by: Ian Lewis <ianlewis@google.com>
Signed-off-by: Noah Elzner <78953604+enteraga6@users.noreply.github.com>
    @enteraga6 @ianlewis
    enteraga6 and ianlewis committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    6cd1257 View commit details
    Browse the repository at this point in the history

  6. set id to nil explicitly 

    Co-authored-by: Ian Lewis <ianlewis@google.com>
Signed-off-by: Noah Elzner <78953604+enteraga6@users.noreply.github.com>
    @enteraga6 @ianlewis
    enteraga6 and ianlewis committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    4fcc8b1 View commit details
    Browse the repository at this point in the history

  7. nit: capitalization 

    Co-authored-by: Ian Lewis <ianlewis@google.com>
Signed-off-by: Noah Elzner <78953604+enteraga6@users.noreply.github.com>
    @enteraga6 @ianlewis
    enteraga6 and ianlewis committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    1a17e0c View commit details
    Browse the repository at this point in the history

  8. nit: remove empty lines 

    Co-authored-by: Ian Lewis <ianlewis@google.com>
Signed-off-by: Noah Elzner <78953604+enteraga6@users.noreply.github.com>
    @enteraga6 @ianlewis
    enteraga6 and ianlewis committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    c98f650 View commit details
    Browse the repository at this point in the history

  9. nit: remove empty lines 

    Co-authored-by: Ian Lewis <ianlewis@google.com>
Signed-off-by: Noah Elzner <78953604+enteraga6@users.noreply.github.com>
    @enteraga6 @ianlewis
    enteraga6 and ianlewis committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    ca9e7ae View commit details
    Browse the repository at this point in the history

  10. remove confusing comment 

    Signed-off-by: Noah Elzner <elzner@google.com>
    @enteraga6
    enteraga6 committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    032b098 View commit details
    Browse the repository at this point in the history

  11. Merge remote-tracking branch 'origin/byob-builder-feat' into byob-bui… 

    …lder-feat
    @enteraga6
    enteraga6 committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    e999450 View commit details
    Browse the repository at this point in the history

  12. nit: remove empty space 

    Signed-off-by: Noah Elzner <elzner@google.com>
    @enteraga6
    enteraga6 committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    1ff4e9b View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. Restructure Tests 

    Signed-off-by: Noah Elzner <elzner@google.com>
    @enteraga6
    enteraga6 committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    e6d22d4 View commit details
    Browse the repository at this point in the history

  2. rename for clarity 

    Signed-off-by: Noah Elzner <elzner@google.com>
    @enteraga6
    enteraga6 committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    b6e36b7 View commit details
    Browse the repository at this point in the history

  3. use t.Errorf 

    Signed-off-by: Noah Elzner <elzner@google.com>
    @enteraga6
    enteraga6 committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    3ba89d9 View commit details
    Browse the repository at this point in the history

  4. Go Lint 

    Signed-off-by: Noah Elzner <elzner@google.com>
    @enteraga6
    enteraga6 committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    7ada2ad View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into byob-builder-feat

    @laurentsimon
    laurentsimon committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    a630e1f View commit details
    Browse the repository at this point in the history

  6. Merged tests and added more 

    Signed-off-by: Noah Elzner <elzner@google.com>
    @enteraga6
    enteraga6 committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    82d0676 View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'origin/byob-builder-feat' into byob-bui… 

    …lder-feat
    @enteraga6
    enteraga6 committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    ba333a5 View commit details
    Browse the repository at this point in the history