feat: handle dssev001 tlog entry types #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
ramonpetgrave64
commented
Aug 13, 2024
| len(env.Signatures), | ||
| len(dsseSchemaObj.Signatures)) | ||
| } | ||
| // TODO(#487): verify the certs match. |
There was a problem hiding this comment.
Copied from the original method. Not all envelopes will have certificates, so that implementation would be opportunistic.
There was a problem hiding this comment.
Can we reuse
slsa-verifier/verifiers/internal/gha/rekor.go
Line 146 in 1694bbf
It's best practice to compare the canonicalized entry for Rekor to what you have (e.g the artifact hash, certificate, and signature, or computing the leaf hash yourself and comparing), since there is a risk of someone swapping out an inclusion proof that is valid but for the wrong entry. Of course, the chance of two signatures being the same is very low, so there isn't really a threat here.
5 tasks
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
loosebazooka
approved these changes
Aug 20, 2024
|
@cmurphy, please take a look |
haydentherapper
approved these changes
Aug 22, 2024
| len(env.Signatures), | ||
| len(dsseSchemaObj.Signatures)) | ||
| } | ||
| // TODO(#487): verify the certs match. |
There was a problem hiding this comment.
Can we reuse
slsa-verifier/verifiers/internal/gha/rekor.go
Line 146 in 1694bbf
It's best practice to compare the canonicalized entry for Rekor to what you have (e.g the artifact hash, certificate, and signature, or computing the leaf hash yourself and comparing), since there is a risk of someone swapping out an inclusion proof that is valid but for the wrong entry. Of course, the chance of two signatures being the same is very low, so there isn't really a threat here.
|
@haydentherapper We can't yet because for the older attestations produce by slsa-github-generator, the certificate was not embedded within the envelope. But that seems like another good reason for #487 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re: slsa-framework/slsa-github-generator#3750
Rekor TLog entries can now be of the type dsse v0.0.1, as when what's returned when using sigstore-go's
Bundle().This is to support eventual Sigstore Bundles produced by slsa-github-generator's "generic" generator, which will likely use sigstore-go's Bundle to produce attestations
Tesing
Followup
Finish the work to produce bundles from the generic generators