make LazyFaultTolerance lock-free #1034
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franz1981
suggested changes
Jul 12, 2024
| @@ -36,15 +37,13 @@ public void run(Runnable action) { | |||
| } | |||
|
|
|||
| private FaultTolerance<T> instance() { | |||
| FaultTolerance<T> instance = this.instance; | |||
| FaultTolerance<T> instance = this.instance.get(); | |||
There was a problem hiding this comment.
this is making builder.get() to be called more than once, changing the expected behaviour for users.
Using ReentrantLock(s) is preferrable here - or use a 2 state lock-free behaviour instead
|
The problem isn't in how heavy the FT builder is, it's in how it creates certain resources; notably, the registration with the circuit breaker maintenance must be done exactly once (subsequent invocations end up with an error IIRC). So a Thanks for working on this BTW, I totally missed that Quarkus issue! |
|
Replace by #1035 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is intended to fix the issue reported here quarkusio/quarkus#41314
Its main drawback is in the fact that with this change multiple threads could concurrently call two or more times the
FaultTolerance builder. I don't know how heavy that invocation actually is, but in case you think that this is not acceptable, the other alternative that I see is replacing that synchronized block with aReentrantLock. Please advice on which of the 2 solutions you prefer.