Fixed bug and added functionality to metapred and fixed tests #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
VMTdeJong
commented
Feb 15, 2024
VMTdeJong
commented
- Fixed bug in metapred where multiple genFUN raised an error. Added parameter to allow for multiple options for handling multiple genFUN and perfFUN simultaneously. Changed gen so that multiple generalizability estimates can be retrieved simultaneously.
- Added tests for multiple generalizability and performance functions in metapred. This should prevent the fixed bug from reoccuring.
- Fixed test that raised an error when plotting valmeta. Note that the statistical issue remains, just the test is fixed.
- Split tests for ccalc and oecalc into three. Note that this highlights an unintended difference in estimates, which fails the test.
This reverts commit e118acf.
Changed CI for valmeta for forest plot, to prevent unnecessary error in test.
Split tests for oecalc into three. Note that this change highlights that the tests fail for Poisson Binomial OE ratio.
Split test for ccalc into three.
Automatic change due to test change
Changed plotting options, per new preferences in ggplot. This also removes warnings in the tests.
Added function for retrieving multiple functions, which metapred uses to find functions.
Changed tests such that manual testing is easier - automatic testing remains functional.
Fixed bug in metapred where multiple genFUN raised an error. Added parameter to allow for multiple options for handling multiple genFUN and perfFUN simultaneously. Changed gen so that multiple generalizability estimates can be retrieved simultaneously.
Added tests for multiple generalizability and performance functions in metapred. This should prevent the fixed bug from reoccuring.
Removed empty sections from Tzoulaki manual
added docs for applying multiple generalizability and performance measures simultaneously in metapred
Added tolerance to tests for oecalc
changed ci to t dist for test of valmeta oe
Added one-stage random effects for metapred, and tests
added option for perf() of metapred
added tests for one-stage models in metapred
fixed perf, which was failing a test for type of output
fixed test for one-stage random effects metapred
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.