Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove Axios in favor of request #40

Conversation

mattmeyerink
Copy link
Contributor

MR to reapply this reverted change that removes request in favor of axios. This MR fixes the issue where PUT/POST request configuration was being improperly passed along to axios causing authorization failures.

@mattmeyerink mattmeyerink force-pushed the personal/mmeyerink/update-http-request-library branch 3 times, most recently from 7f3d7e7 to c189f71 Compare September 12, 2023 00:02
package-lock.json Outdated Show resolved Hide resolved
lib/utils/httpRequestor.js Show resolved Hide resolved
@mattmeyerink mattmeyerink force-pushed the personal/mmeyerink/update-http-request-library branch from c189f71 to 2d94251 Compare September 15, 2023 00:15
@mattmeyerink mattmeyerink force-pushed the personal/mmeyerink/update-http-request-library branch from 2d94251 to 7df1535 Compare October 19, 2023 14:31
@mattmeyerink mattmeyerink requested review from joshualoehr-smar and Scomodev and removed request for joshualoehr-smar October 19, 2023 14:51
@mattmeyerink mattmeyerink merged commit 9c0e004 into smartsheet:mainline Oct 20, 2023
5 checks passed
@mattmeyerink mattmeyerink deleted the personal/mmeyerink/update-http-request-library branch October 26, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants