Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/scmorrison/handle rejections #42

Merged
merged 3 commits into from
Oct 20, 2023
Merged

Fix/scmorrison/handle rejections #42

merged 3 commits into from
Oct 20, 2023

Conversation

Scomodev
Copy link
Contributor

FIX

  • fix how we pass the error object to the response handler
  • we no longer need to return a promise.reject from response handler
  • update tests around response handler and retries for handling errors

mattmeyerink
mattmeyerink approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@mattmeyerink mattmeyerink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this fix also. Testing changes make sense based on the needed handleResponse changes.

@Scomodev Scomodev merged commit 95fe296 into smartsheet:mainline Oct 20, 2023
5 checks passed
@Scomodev Scomodev mentioned this pull request Oct 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmeyerink mattmeyerink mattmeyerink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Scomodev @mattmeyerink