Chore coroutine version bump #580
Conversation
There was a problem hiding this comment.
What's the scope for updating APIs that use integers as durations? The retry classes use integer milliseconds in StandardRetryStrategyOptions and ExponentialBackoffWithJitterOptions.
runtime/io/build.gradle.kts
Outdated
| @@ -25,6 +25,7 @@ kotlin { | |||
| commonTest { | |||
| dependencies { | |||
| implementation(project(":runtime:testing")) | |||
There was a problem hiding this comment.
I'm guessing we don't need this dependency in a lot of places anymore since most usages of it were to pull in runSuspendTest.
Not sure which projects are still using the other capabilities that remain.
There was a problem hiding this comment.
It seems that there are none, as I removed them all and nothing broke... 🤷
| import kotlin.test.Test | ||
| import kotlin.test.assertEquals | ||
| import kotlin.test.assertFails | ||
|
|
||
| @OptIn(ExperimentalCoroutinesApi::class) |
There was a problem hiding this comment.
question
What API is experimental that we have to opt-in to? (haven't played with the new APIs yet)
There was a problem hiding this comment.
the new runTests provided by coroutines-test is experimental
| @@ -95,11 +97,11 @@ class MutateHeadersTest { | |||
| // should leave in existing | |||
| assertEquals("qux", call.request.headers["baz"]) | |||
|
|
|||
| return@runSuspendTest | |||
| return@runTest | |||
There was a problem hiding this comment.
question
Do we even need these returns?
There was a problem hiding this comment.
I didn't notice this. No, removed.
| "Took more than ${options.maxTimeMs}ms to yield a result", | ||
| "Took more than ${options.maxTime}ms to yield a result", |
There was a problem hiding this comment.
Nit: The literal "ms" is now unnecessary. Duration.toString already formats units alongside values.
|
Kudos, SonarCloud Quality Gate passed!
|
Companion PR: awslabs/aws-sdk-kotlin#514
Issue #
awslabs/aws-sdk-kotlin#513
Description of changes