Refactored QLDB code examples #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed crates in Cargo.toml
rcoh
reviewed
Jun 29, 2021
| let result = client | ||
| .send_command() | ||
| .start_session(StartSessionRequest::builder().ledger_name(ledger).build()) | ||
| .send() | ||
| .await?; | ||
| .await | ||
| .expect("Could not start a session"); |
There was a problem hiding this comment.
we could probably be leaning towards ? over .expect(). In general, we should be leading customers away from code that will panic
rcoh
approved these changes
Jun 30, 2021
rcoh
pushed a commit
that referenced
this pull request
Jun 30, 2021
* Refactored QLDB code examples to use common example pattern; re-ordered crates in Cargo.toml * Updated QLDB helloworld code example to use ? instead of expect()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.