feat: give SigV4 its own header formatter to avoid import of entire eventstream-codec package #1233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ventstream-codec package
|
this reduces bundle size as shown in #1159 and also reduces the number of files loaded in a non-bundled Node.js program by ~10 or 10% when not using an eventstream-featuring client. |
AndrewFossAWS
approved these changes
Apr 4, 2024
|
Thank you for this PR, appreciate it! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
fixes #1159
Description of changes:
temporarily duplicates the header formatting functionality from evenstream-codec to signature-v4 so that sigv4 does not have to import the entire eventstream-codec package and transitively the large-ish aws-crypto packages.
when Node.js 14 support is dropped, our typescript config will support submodules (package.json:exports) and then the headerMarshaller functionality can be reunified as a single submodule of e.g.
@smithy/core.