Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update engines to node16 #1258

Merged
merged 8 commits into from
May 7, 2024
Merged

chore: update engines to node16 #1258

merged 8 commits into from
May 7, 2024

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented May 7, 2024

  • drops support for node14
  • major version bump for all non-experimental packages
  • remove package-level @tsconfig/recommended dependency since it was unused
  • added lint:versions to ensure consistent cross-package dependency versions

I confirmed that the generated code in dist-cjs does not change at all from this PR.

@kuhe kuhe requested review from a team as code owners May 7, 2024 16:27
@kuhe kuhe requested a review from haydenbaker May 7, 2024 16:27
Copy link
Contributor

@syall syall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note: we need a SSDK libs release, similar to #738

@kuhe kuhe merged commit 671aa70 into smithy-lang:main May 7, 2024
7 checks passed
@kuhe kuhe deleted the chore/node16 branch May 7, 2024 19:58
kuhe added a commit to kuhe/smithy-typescript that referenced this pull request May 28, 2024
* chore: update engines to node16

* chore: update all engines to node16

* chore: update yarn lock

* chore: changeset

* chore: update test-typescript action to use node16

* chore: additional node16 updates

* chore: node16

* chore: undo hand edit version bump
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants