Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(event-streams): use member name as :event-type header value #1349

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Jul 24, 2024

When serializing the headers for an event stream event, the :event-type should take on the member name and not the member target id.

  const headers: __MessageHeaders = {
    ":event-type": { type: "string", value: "textEvent" }, // <-- here, for example
    ":message-type": { type: "string", value: "event" },
    ":content-type": { type: "string", value: "application/json" },
  };

This had not manifested until a recent AWS service in which the two values were not identical for apparently the first time.

@kuhe kuhe requested review from a team as code owners July 24, 2024 22:34
@kuhe kuhe requested a review from JordonPhillips July 24, 2024 22:34
@kuhe kuhe self-assigned this Jul 24, 2024
@kuhe kuhe merged commit a7843ad into smithy-lang:main Jul 24, 2024
19 of 20 checks passed
@kuhe kuhe deleted the fix/eventstream branch July 24, 2024 23:48
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants