feat(experimentalIdentityAndAuth): enable identity and auth by default #1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
taking over from #1326, leaving it as reference |
kuhe
changed the title
|
The diff for this PR is seen in aws/aws-sdk-js-v3#6299 |
3 tasks
hpmellema
requested changes
Jul 29, 2024
...degen/src/main/java/software/amazon/smithy/typescript/codegen/DirectedTypeScriptCodegen.java
Outdated
Show resolved
Hide resolved
...script-codegen/src/main/java/software/amazon/smithy/typescript/codegen/CommandGenerator.java
Outdated
Show resolved
Hide resolved
...script-codegen/src/main/java/software/amazon/smithy/typescript/codegen/CommandGenerator.java
Outdated
Show resolved
Hide resolved
...src/main/java/software/amazon/smithy/typescript/codegen/ServiceBareBonesClientGenerator.java
Outdated
Show resolved
Hide resolved
...ain/java/software/amazon/smithy/typescript/codegen/integration/AddEventStreamDependency.java
Outdated
Show resolved
Hide resolved
...software/amazon/smithy/typescript/codegen/auth/http/integration/AddHttpAuthSchemePlugin.java
Outdated
Show resolved
Hide resolved
`experimentalIdentityAndAuth` behavior is now the default auth behavior. The `experimentalIdentityAndAuth` flag is now oppositely replaced with `useLegacyAuth`, which enables legacy auth behavior for backward compatibility concerns.
hpmellema
approved these changes
Jul 30, 2024
trivikr
approved these changes
Jul 30, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Derived from:
mutateClientPlugins()integration hook #1322experimentalIdentityAndAuthbehavior is now the default auth behavior.The
experimentalIdentityAndAuthflag is now oppositely replaced withuseLegacyAuth, which enables legacy auth behavior for backwardcompatibility concerns.
Expected diff in clients can be seen in the linked SDK PR.
This PR changes the resolution order of some plugins. This is safe since the plugins declare any dependencies in their input and resolved types such that any hard requirements in ordering will express as TypeScript compilation errors.
This PR moves some private client methods inline.