Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use string join instead of templates #1354

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Jul 30, 2024

switches back to using string join because templating escapes the string which may include smithy syntax

@kuhe kuhe requested review from a team as code owners July 30, 2024 20:42
@kuhe kuhe requested a review from sugmanue July 30, 2024 20:42
@kuhe kuhe merged commit 354d175 into smithy-lang:main Jul 30, 2024
9 of 10 checks passed
@kuhe kuhe deleted the fix/add-params branch July 30, 2024 20:46
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants