fix(endpoints): resolve service-specific endpoint once per client #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
force-pushed
the
feat/endpoints
branch
6 times, most recently
from
28f42dd
to
71b17e3
Compare
kuhe
commented
Aug 29, 2024
| @@ -39,9 +39,19 @@ export const getEndpointFromInstructions = async < | |||
| context?: HandlerExecutionContext | |||
| ): Promise<EndpointV2> => { | |||
| if (!clientConfig.endpoint) { | |||
| const endpointFromConfig = await getEndpointFromConfig(clientConfig.serviceId || ""); | |||
There was a problem hiding this comment.
the issue was that this call involved a call to loadConfig for every request, which calls memoize rather than calling a memoized function, leading to repeated calls to fs.
There was a problem hiding this comment.
this delayed every request by around 50ms in my testing
There was a problem hiding this comment.
edit: "slurpFile" has a cache, but it is several functions/modules deep in terms of unnecessary calls
trivikr
approved these changes
Aug 29, 2024
Closed
1 task
milesziemer
approved these changes
Aug 30, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aws/aws-sdk-js-v3#6423
loadConfig