Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): add interface stub for RequestInit #1403

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Sep 13, 2024

  • adds interface stub for RequestInit global

RequestInit was already used in the fetch-http-handler, but that is only conditionally compiled if the user imports it or bundles web-based code that imports the browser runtimeConfig files.

The usage of RequestInit in the types package, which is not conditionally loaded, must be accompanied by the interface merging stub.

@kuhe
Copy link
Contributor Author

kuhe commented Sep 13, 2024

revision 2: changed to use the RequestInit type unconditionally instead of never when its a stub

@kuhe kuhe merged commit e7b438b into smithy-lang:main Sep 13, 2024
10 of 11 checks passed
@kuhe kuhe deleted the fix/types branch September 13, 2024 20:44
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants