Support removing unused mixins #1951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sugmanue
approved these changes
Aug 25, 2023
mtdowling
approved these changes
Aug 25, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
FlattenAndRemoveMixins only removes mixins if it flattened 1 or more shapes.
This can cause mixins to leak into downstream code generators (when we really want them inlined).
Specifically, if a Model has mixins which are all unused, it will trigger this behavior. But if at least 1 mixin was flattened into a shape, all mixins will be removed (including unused ones). This can happen in shared Smithy model packages that are meant to be used by multiple downstream services.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.