Re-add validator to check consistency of resource names #1954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…source Validator was previously reverted in 859e82d.
mtdowling
approved these changes
Aug 28, 2023
kstich
approved these changes
Aug 28, 2023
alextwoods
pushed a commit
to alextwoods/smithy
that referenced
this pull request
Sep 15, 2023
…source (smithy-lang#1954) Adds validator to check for consistency between resource names, iamResource traits, and arn traits.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Re-add validator to check consistency of resource name used for IamResource
Validator was previously reverted in 859e82d.
The validator now ignores arns marked as
absolute.See original PR: #1819
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.