Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XML string payload protocol test #2007

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Conversation

davidh44
Copy link
Contributor

Issue #, if available:

Description of changes:
Add string payload test for restXml, similar to existing restJson test.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@davidh44 davidh44 requested a review from a team as a code owner October 11, 2023 22:18
@srchase srchase self-assigned this Oct 11, 2023
code: 200
}
])
operation HttpEnumPayload {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This operation and the one below need to be added to the RestXml service, otherwise code generators won't pick it up and generate the appropriate tests from it. See where the equivalent operations are added to the RestJson service here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added operations and fixed namespace

@srchase
Copy link
Contributor

srchase commented Oct 12, 2023

After generating updated tests for AWS SDK JS V3, running yarn test:protocols yields the following successful test:

lerna success run Ran npm script 'test' in 6 packages in 20.0s:
lerna success - @aws-sdk/aws-protocoltests-ec2
lerna success - @aws-sdk/aws-protocoltests-json-10
lerna success - @aws-sdk/aws-protocoltests-json
lerna success - @aws-sdk/aws-protocoltests-query
lerna success - @aws-sdk/aws-protocoltests-restjson
lerna success - @aws-sdk/aws-protocoltests-restxml
Done in 188.22s.

@srchase srchase merged commit 1251dc2 into smithy-lang:main Oct 12, 2023
10 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants