Add an official MSRV policy #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
reviewed
Dec 28, 2022
notgull
force-pushed
the
msrv
branch
2 times, most recently
from
b802ac3
to
00a1b13
Compare
taiki-e
reviewed
Dec 29, 2022
There was a problem hiding this comment.
LGTM. Could you also update the comment in ci.yml?
Lines 47 to 49 in 0ae00da
from:
Rust version in Cargo.toml.
to:
Rust version in Cargo.toml and README.md.
taiki-e
reviewed
Jan 15, 2023
taiki-e
approved these changes
Jan 15, 2023
|
Merged. Thanks for working on this! |
|
No problem! I'll use this as a template for other repositories in this organization. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, the unofficial MSRV policy of the
smol-rsorganization is to keep the MSRV at or below the current Debian stable version. However, as far as I know this is never written down anywhere. Therefore, this PR attempts to codify this policy.I can add this to the other crates in the
smol-rsorganization if this is approved.