feat: Set implies_no_shared_fs=False #24
Conversation
WalkthroughThe change involves a modification in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Files selected for processing (1)
- snakemake_executor_plugin_kubernetes/init.py (1 hunks)
Additional context used
Path-based instructions (1)
snakemake_executor_plugin_kubernetes/__init__.py (1)
Pattern
**/*.py: Do not suggest to add trailing commas for improving formatting.
Do not try to improve formatting.
Do not suggest type annotations for functions that are defined inside of functions or methods.
Do not suggest type annotation of theselfargument of methods.
Do not suggest type annotation of theclsargument of classmethods.
Do not suggest return type annotation if a function or method does not explicitly return anything.
Additional comments not posted (1)
snakemake_executor_plugin_kubernetes/__init__.py (1)
112-112: LGTM! But verify the consistency ofimplies_no_shared_fsusage.The change to set
implies_no_shared_fstoFalseis approved.Ensure that this change is consistent with the intended behavior across the codebase, particularly in how shared filesystems are managed in different execution contexts.
Verification successful
No further references to
implies_no_shared_fsfound.The
implies_no_shared_fsvariable is only present in thesnakemake_executor_plugin_kubernetes/__init__.pyfile, and there are no other references in the codebase. This suggests that the change does not affect other parts of the code.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage and impact of `implies_no_shared_fs` across the codebase. # Test: Search for references to `implies_no_shared_fs`. Expect: Consistent usage with the new setting. rg --type python 'implies_no_shared_fs'Length of output: 70
Script:
#!/bin/bash # Description: Verify the usage and impact of `implies_no_shared_fs` across the codebase. # Test: Search for references to `implies_no_shared_fs` across all files. rg 'implies_no_shared_fs'Length of output: 106
jns
changed the title
|
Withdrawing pull request. Snakemake fails to launch K8s pods in some situations when the parameters is false. |
The addition of persistent-volumes in v0.2.0 permits mounting of shared volume in each pod, which is effectively a shared-fs. This PR removes the
implies_no_shared_fsconstraint on the kubernetes executor so that persistent volumes can be utilized as a shared-fs.Summary by CodeRabbit
New Features
Bug Fixes