Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS SDK V3 support #365

Closed
cjnoname opened this issue Nov 20, 2022 · 14 comments
Closed

AWS SDK V3 support #365

cjnoname opened this issue Nov 20, 2022 · 14 comments
Assignees
Labels
enhancement The issue is a request for improvement or a new feature

Comments

@cjnoname
Copy link

Hi,

I want to understand why the AWS SDK v3 changes were reverted two months ago? Now AWS Lambda support NodeJS 18 which supports SDK v3 natively.

Thanks,
CJ

@netroy
Copy link

netroy commented Jan 9, 2023

@SimbaGithub @sfc-gh-kdama We'd like to also upgrade to a version of snowplow sdk that uses the AWS SDK v3.
Can you please add more context on why the change was reverted, and if there is anything we can help to move this forward 🙏🏽 .

@1davidmichael
Copy link

This warning is now output when using snowflake-connector-nodejs:

NOTE: The AWS SDK for JavaScript (v2) will be put into maintenance mode in 2023.

Hopefully this can be addressed before v2 of the AWS SDK is put in maintenance mode.

@fdmarc
Copy link

fdmarc commented Feb 21, 2023

I just got the same warning message when using the Snowflake SDK. +1 on this issue.

@pjprijs
Copy link

pjprijs commented Feb 23, 2023

same here, please upgrade package to use AWS SDK v3

@sfc-gh-dszmolka
Copy link
Collaborator

hi, for the warning message

(node:39752) NOTE: We are formalizing our plans to enter AWS SDK for JavaScript (v2) into maintenance mode in 2023.

Please migrate your code to use AWS SDK for JavaScript (v3).
For more information, check the migration guide at https://a.co/7PzMCcy
(Use `node --trace-warnings ...` to show where the warning was created)

if you wish, you can suppress it with adding

require('aws-sdk/lib/maintenance_mode_message').suppress = true;

(from comments in https://github.com/aws/aws-sdk-js/blob/master/lib/maintenance_mode_message.js#L14) until we can deal properly with the issue. thank you for bearing with us !

@robfig
Copy link

robfig commented Mar 14, 2023

This is our last dependency on AWS v2 before we can drop that 85MB dependency from our builds. Excited for it, thank you!

@sfc-gh-dszmolka sfc-gh-dszmolka added enhancement The issue is a request for improvement or a new feature status-in_progress Issue is worked on by the driver team labels Mar 29, 2023
@rrajaravi
Copy link

same here - this is our last dependency on AWS V2, please upgrade package to use AWS SDK v3

@joseph-skupniewicz-sp
Copy link

Yep- seeing this warning also. Please upgrade to use AWS SDK v3 thank you!

@sahilkul95
Copy link

same here - this is our last dependency on AWS v2. Requesting for upgrade to v3 soon please. Or at least please declare the date of release.
Would be a great help. Thanks a lot!

@sfc-gh-dszmolka
Copy link
Collaborator

got now some info on the roadmap; this is planned for Q3 at this moment. i wish i had better news but that's what it is.

what you can do, if you're already a Snowflake customer, please reach out to your Sales rep. and explain why this would be important for you to be implemented sooner (they have some tools at their disposal to make requests more important)

i'll keep this thread updated with any new info as they become available to me.

@sfc-gh-dszmolka
Copy link
Collaborator

although there's still work to do, but this issue is still on the table and we're working on it (#616 ) . thank you everyone for bearing with us while this is implemented - will keep this updated.

@sahilkul95
Copy link

got now some info on the release: This is probably being planned for the next month release as per #616 (comment)

@sfc-gh-dszmolka
Copy link
Collaborator

#616 merged and will be part of the next release, expected towards end of September

@sfc-gh-dszmolka sfc-gh-dszmolka added status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. and removed status-in_progress Issue is worked on by the driver team labels Sep 15, 2023
@sfc-gh-dszmolka
Copy link
Collaborator

fix is now out with release 1.9.0 , available on npm as well

@sfc-gh-dszmolka sfc-gh-dszmolka removed the status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. label Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue is a request for improvement or a new feature
Projects
None yet
Development

No branches or pull requests